Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move feature gates CronJobTimeZone, JobMutableNodeSchedulingDirectives and LegacyServiceAccountTokenNoAutoGeneration to feature-gates-removed page #43400

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Move feature gates CronJobTimeZone, JobMutableNodeSchedulingDirectives and LegacyServiceAccountTokenNoAutoGeneration to feature-gates-removed page #43400

merged 1 commit into from
Oct 17, 2023

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Oct 10, 2023

Move feature gates CronJobTimeZone, JobMutableNodeSchedulingDirectives and LegacyServiceAccountTokenNoAutoGeneration to feature-gates-removed page

Ref: kubernetes/kubernetes#120192

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kbhawkey October 10, 2023 03:08
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 10, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 10, 2023
@SataQiu
Copy link
Member Author

SataQiu commented Oct 10, 2023

/hold

wait kubernetes/kubernetes#120192 to be merged first.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@SataQiu SataQiu mentioned this pull request Oct 10, 2023
Merged
@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9b467c1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65264c5efc4cc70008d75c5e
😎 Deploy Preview https://deploy-preview-43400--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Oct 10, 2023

@SataQiu Could you help do us a favor by evaluating whether switching to a per-gate description file helps simply this change?
I'm referring to #41793.

@Shubham82
Copy link
Contributor

@SataQiu these feature gates will be removed in k8s v1.29, so these changes will be done in the dev-1.29 branch not in the main branch.

@SataQiu SataQiu changed the base branch from main to dev-1.29 October 11, 2023 05:58
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2023
@SataQiu SataQiu changed the base branch from dev-1.29 to main October 11, 2023 05:59
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 11, 2023
@SataQiu SataQiu force-pushed the update-featuregates-20231010 branch from c9820e2 to 9b467c1 Compare October 11, 2023 07:18
@SataQiu SataQiu changed the base branch from main to dev-1.29 October 11, 2023 07:19
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 11, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 11, 2023

/approve
from docs side.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 11, 2023
@SataQiu
move feature gates CronJobTimeZone, JobMutableNodeSchedulingDirective…
3768e3f 
…s and LegacyServiceAccountTokenNoAutoGeneration to feature-gates-removed page
@SataQiu SataQiu force-pushed the update-featuregates-20231010 branch from 9b467c1 to 3768e3f Compare October 16, 2023 01:51
@netlify
Copy link

netlify bot commented Oct 16, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 3768e3f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/652c972bb66d9c00085fe08d

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2023
@SataQiu
Copy link
Member Author

SataQiu commented Oct 16, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2023
@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4c2e109d0cc0a07dc3438fa3ffdff69003684de8

@k8s-ci-robot k8s-ci-robot merged commit a7d7ebb into kubernetes:dev-1.29 Oct 17, 2023
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

Assignees

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
4 participants
@SataQiu @tengqm @Shubham82 @k8s-ci-robot